John McCain vs. Trump

The Senator is a war hero because as a Navy pilot of his rank he was exempted from flying above a certain parallel in attacking North Vietnam. Obviously defenses near Haiphong were better and flying further North was more dangerous. He declined the privilege of flying in more relatively safe areas only and was shot down. Yes, his behavior in captivity plays some role in his being considered a hero, but it starts with his willingness to take risks in the attack. Trump on the other hand plays on feelings of anger and humiliation while seeming to lead people into more dangerous areas.